Rudi Grinberg
d30361a180
Fix overly strict validation of invalid names
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-08 15:07:26 +03:00
Rudi Grinberg
ca7696f2c3
Add test case for a library with an invalid name
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-08 15:07:26 +03:00
Rudi Grinberg
5706e4ee56
Make invalid public name warn when (wrapped false)
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-08 15:07:26 +03:00
Rudi Grinberg
c08cec1f4b
Add test case for name when it doesn't matter
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-08 15:07:26 +03:00
Rudi Grinberg
925bc84427
Fix error message
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-08 15:07:26 +03:00
Rudi Grinberg
272012ea5c
Update CHANGELOG
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-08 15:07:26 +03:00
Rudi Grinberg
31e4f6f18a
Fix error messages for invalid lib names
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-08 15:07:26 +03:00
Rudi Grinberg
131310d144
Fix validation of library names
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-08 15:07:26 +03:00
Rudi Grinberg
317388fd95
Refactor code to to have a dedicated type for Library.name
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-08 15:07:26 +03:00
Rudi Grinberg
6260dad66b
Remove comment that was comitted accidentally
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-08 15:07:26 +03:00
Rudi Grinberg
67c6de4864
Add test for #1102
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-08 15:07:26 +03:00
Rudi Grinberg
0c1809230e
Merge pull request #1113 from ocaml/mark-external-deps
...
Mark more tests as having external deps
2018-08-08 11:19:55 +03:00
Rudi Grinberg
63b49f946b
Mark more tests as having external deps
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-08 01:30:22 +03:00
Rudi Grinberg
0ec0f4d279
Merge pull request #1108 from rgrinberg/fix-1107
...
Fix #1107
2018-08-07 13:06:24 +03:00
Rudi Grinberg
12bf6bda4a
Fix #1107
...
-opaque should be passed for mli only modules or for all modules when opaque
mode is on
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-07 13:05:37 +03:00
Etienne Millon
0f18a6e047
Merge pull request #1109 from ocaml/fix-1106
...
Do not duplicate profile in missing deps message (fixes #1106 )
2018-08-07 11:56:49 +02:00
Etienne Millon
f5c45a72a8
Do not duplicate profile in missing deps message
...
Closes #1106
Signed-off-by: Etienne Millon <me@emillon.org>
2018-08-07 09:53:34 +00:00
Rudi Grinberg
ecd29a1c81
Update CHANGES
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-07 12:17:17 +03:00
Rudi Grinberg
a689081550
Merge pull request #1105 from rgrinberg/1101
...
Fix #1101
2018-08-07 12:14:21 +03:00
Rudi Grinberg
9a504bc86a
Remove pointless polymorphic variant and check_path
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-07 11:42:25 +03:00
Rudi Grinberg
6dc6ac3668
Fix #1101
...
Do not attempt to convert string -> path -> string as this loses information
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-07 11:42:25 +03:00
Rudi Grinberg
264263c819
Split target resolution from string -> path conversion
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-07 11:42:25 +03:00
Rudi Grinberg
6197a49c41
Simplify target resolution code
...
Split it into 3 functinos
* Resolve 1 targets
* Do logging
* Resolve all targets
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-07 11:42:25 +03:00
Rudi Grinberg
a3c6f417d0
Add test case for 1101
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-07 11:42:25 +03:00
Rudi Grinberg
b616c7e56d
Merge pull request #1104 from rgrinberg/fix-1103
...
Fix 1103
2018-08-07 10:39:32 +03:00
Rudi Grinberg
f74a064aed
Fix #1103
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-07 00:36:27 +03:00
Rudi Grinberg
99e0686447
Test case for --dev bug
...
jbuilder doesn't accept --dev like it should
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-07 00:34:35 +03:00
Rudi Grinberg
58d0ccb713
Update CHANGES for 1.1.0
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-06 15:59:18 +03:00
Etienne Millon
48ece7ffe6
Merge pull request #1091 from ocaml/compiler-version-predicates
...
Extract predicates for compiler versions
2018-08-06 14:28:42 +02:00
Etienne Millon
4bacf48a89
Extract predicates for compiler versions
...
Instead of comparing on the version numbers, add some predicates in a
new `Ocaml_version` module that describe the compiler behavior.
Signed-off-by: Etienne Millon <me@emillon.org>
2018-08-06 11:49:03 +00:00
Rudi Grinberg
7c597d80e7
Merge pull request #1096 from rgrinberg/missing-loc
...
Missing loc
2018-08-06 14:30:15 +03:00
Rudi Grinberg
295ba113d5
Merge pull request #1098 from shonfeder/update-hacking-readme
...
Update HACKING.md to refer to Dune instead of JBuilder
2018-08-06 10:39:55 +03:00
Shon Feder
e58cdbbae4
Update HACKING.md to refer to Dune instead of JBuilder
...
A handful of `jbuild` references remain, reflecting source code file names.
Signed-off-by: Shon Feder <shon.feder@gmail.com>
2018-08-05 18:57:42 -04:00
Rudi Grinberg
fe6fae0ff0
Avoid using a _ pattern where it's not necessary
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-05 22:00:05 +03:00
Jeremie Dimino
0e6dda2032
Adapt the design of multi directory libraries
...
Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
2018-08-05 21:58:21 +03:00
Rudi Grinberg
66f2004f8f
Add rule locs to failed rules
...
this will add a location that will point to the rule that failed
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-04 20:03:58 +03:00
Rudi Grinberg
b9cbdd236b
Add test case for deps field
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-04 19:59:16 +03:00
Rudi Grinberg
b3d87dc163
Update CHANGES
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-04 13:22:19 +03:00
Rudi Grinberg
a064b59692
Track locations when executing programs
...
Only works for searched programs for now
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-04 13:16:58 +03:00
Rudi Grinberg
4483627348
Add tests for missing locations when running programs
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-04 13:16:00 +03:00
Rudi Grinberg
d484f7b0fa
Merge pull request #1093 from rgrinberg/dir_contents_modules
...
Refactor error detection for modules
2018-08-03 18:35:58 +03:00
Etienne Millon
23e7273934
Merge pull request #1092 from ocaml/doc-tests-use-stanza
...
Quickstart: use short test stanza
2018-08-03 15:44:31 +02:00
Rudi Grinberg
7fb18ebbd3
Decouple error detection from reporting in modules field
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-03 16:29:38 +03:00
Etienne Millon
00f895bb09
Quickstart: use short test stanza
...
In addition, document convention for expect tests.
Signed-off-by: Etienne Millon <me@emillon.org>
2018-08-03 11:49:28 +00:00
Rudi Grinberg
3667db05fc
Move module validation to own function
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-03 11:48:32 +03:00
Rudi Grinberg
51ca4f7659
Simplify returning modules in Dir_contents.eval
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-03 11:42:30 +03:00
Rudi Grinberg
55dbe740c6
Fix typo in CHANGELOG s/qualified/unqalified/
...
Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
2018-08-02 21:04:38 +02:00
Rudi Grinberg
45e3335982
Merge pull request #1090 from ocaml/fix-dune-subst-doc
...
Fix placeholders in dune subst documentation
2018-08-02 20:41:09 +02:00
Etienne Millon
7129564d12
Fix placeholders in dune subst documentation
...
They were substituted, leading to confusing documentation.
Signed-off-by: Etienne Millon <me@emillon.org>
2018-08-02 14:30:59 +00:00
Rudi Grinberg
7132e6eb55
Merge pull request #1079 from rgrinberg/opaque
...
Opaque Mode
2018-08-02 16:30:14 +02:00