From 020774e89886ac07c86f6799cf742891c7735077 Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Wed, 11 Jul 2018 04:24:52 +0700 Subject: [PATCH] Remove ppx test that relies on ppx_driver ppx_driver.runner is deprecated so we can't really test it effectively when the latest ppxlib is installed. Signed-off-by: Rudi Grinberg --- test/blackbox-tests/test-cases/ppx-rewriter/jbuild | 10 ---------- test/blackbox-tests/test-cases/ppx-rewriter/run.t | 8 +------- .../test-cases/ppx-rewriter/w_ppx_driver.ml | 0 .../test-cases/ppx-rewriter/w_ppx_driver_flags.ml | 0 4 files changed, 1 insertion(+), 17 deletions(-) delete mode 100644 test/blackbox-tests/test-cases/ppx-rewriter/w_ppx_driver.ml delete mode 100644 test/blackbox-tests/test-cases/ppx-rewriter/w_ppx_driver_flags.ml diff --git a/test/blackbox-tests/test-cases/ppx-rewriter/jbuild b/test/blackbox-tests/test-cases/ppx-rewriter/jbuild index 81ce945b..0b4e4abd 100644 --- a/test/blackbox-tests/test-cases/ppx-rewriter/jbuild +++ b/test/blackbox-tests/test-cases/ppx-rewriter/jbuild @@ -4,13 +4,3 @@ ((name w_omp_driver) (modules w_omp_driver) (preprocess (pps (fooppx -flag (-arg omp)))))) - -(executable - ((name w_ppx_driver) - (modules w_ppx_driver) - (preprocess (pps (ppx_driver.runner))))) - -(executable - ((name w_ppx_driver_flags) - (modules w_ppx_driver_flags) - (preprocess (pps (fooppx -flag (-arg omp) ppx_driver.runner))))) diff --git a/test/blackbox-tests/test-cases/ppx-rewriter/run.t b/test/blackbox-tests/test-cases/ppx-rewriter/run.t index 48375ef1..bb670e8c 100644 --- a/test/blackbox-tests/test-cases/ppx-rewriter/run.t +++ b/test/blackbox-tests/test-cases/ppx-rewriter/run.t @@ -9,13 +9,7 @@ ocamlc .w_omp_driver.eobjs/w_omp_driver.{cmi,cmo,cmt} ocamlopt .w_omp_driver.eobjs/w_omp_driver.{cmx,o} ocamlopt w_omp_driver.exe - $ dune build ./w_ppx_driver.exe --display short - ocamlopt .ppx/jbuild/ppx_driver.runner/ppx.exe - ppx w_ppx_driver.pp.ml - ocamldep .w_ppx_driver.eobjs/w_ppx_driver.pp.ml.d - ocamlc .w_ppx_driver.eobjs/w_ppx_driver.{cmi,cmo,cmt} - ocamlopt .w_ppx_driver.eobjs/w_ppx_driver.{cmx,o} - ocamlopt w_ppx_driver.exe + This test is broken because ppx_driver doesn't support migrate custom arguments # $ dune build ./w_ppx_driver_flags.exe --display short $ dune build && dune exec -- ocamlfind opt -package fooppx -ppxopt "fooppx,-flag" -linkpkg w_omp_driver.ml -o w_omp_driver.exe diff --git a/test/blackbox-tests/test-cases/ppx-rewriter/w_ppx_driver.ml b/test/blackbox-tests/test-cases/ppx-rewriter/w_ppx_driver.ml deleted file mode 100644 index e69de29b..00000000 diff --git a/test/blackbox-tests/test-cases/ppx-rewriter/w_ppx_driver_flags.ml b/test/blackbox-tests/test-cases/ppx-rewriter/w_ppx_driver_flags.ml deleted file mode 100644 index e69de29b..00000000