From fad2873ad7faac1dbef79e97ff6c4eee5212a70d Mon Sep 17 00:00:00 2001 From: Jeremie Dimino Date: Tue, 28 Feb 2017 13:20:35 +0000 Subject: [PATCH] Update warning for .mli only modules --- src/gen_rules.ml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/gen_rules.ml b/src/gen_rules.ml index 2b8f8c94..0f80be40 100644 --- a/src/gen_rules.ml +++ b/src/gen_rules.ml @@ -1463,9 +1463,14 @@ module Gen(P : Params) = struct let mli_fname = Option.value_exn mli_fname in let ml_fname = String.sub mli_fname ~pos:0 ~len:(String.length mli_fname - 1) in Format.eprintf - "@{Warning@}: module %s in %s doesn't have a corresponding\ - .ml file.\n\ - I'm setting up a rule for copying %s to %s.\n" + "@{Warning@}: Module %s in %s doesn't have a \ + corresponding .ml file.\n\ + Modules without an implementation are not recommended, \ + see this discussion:\n\ + \n\ + \ https://github.com/janestreet/jbuilder/issues/9\n\ + \n\ + In the meantime I'm setting up a rule for copying %s to %s.\n" name (Path.to_string dir) mli_fname ml_fname; let dir = Path.append ctx.build_dir dir in