Merge pull request #786 from rgrinberg/fix-784

Fix 784

src/build_interpret.ml

@@ -206,7 +206,10 @@ module Rule = struct
     let dir =
       match targets with
       | [] ->
-        invalid_arg "Build_interpret.Rule.make: rule has no targets"
+        begin match loc with
+        | Some loc -> Loc.fail loc "Rule has no targets specified"
+        | None -> Exn.code_error "Build_interpret.Rule.make: no targets" []
+        end
       | x :: l ->
         let dir = Path.parent_exn (Target.path x) in
         List.iter l ~f:(fun target ->

test/blackbox-tests/dune.inc

@@ -227,6 +227,14 @@
      (run ${exe:cram.exe} -skip-platforms win -test run.t)
      (diff? run.t run.t.corrected))))))
 
+(alias
+ ((name github784)
+  (deps ((package dune) (files_recursively_in test-cases/github784)))
+  (action
+   (chdir
+    test-cases/github784
+    (progn (run ${exe:cram.exe} -test run.t) (diff? run.t run.t.corrected))))))
+
 (alias
  ((name ignored_subdirs)
   (deps ((package dune) (files_recursively_in test-cases/ignored_subdirs)))
@@ -522,6 +530,7 @@
     (alias github759)
     (alias github761)
     (alias github764)
+    (alias github784)
     (alias ignored_subdirs)
     (alias include-loop)
     (alias inline_tests)
@@ -579,6 +588,7 @@
     (alias github759)
     (alias github761)
     (alias github764)
+    (alias github784)
     (alias ignored_subdirs)
     (alias include-loop)
     (alias inline_tests)

test/blackbox-tests/test-cases/github784/dune

@@ -0,0 +1 @@
+(rule (run ${bin:echo} foo))

test/blackbox-tests/test-cases/github784/run.t

@@ -0,0 +1,4 @@
+  $ dune build
+  File "dune", line 1, characters 0-28:
+  Error: Rule has no targets specified
+  [1]