Do not silently ignore closure errors
cc @diml Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
This commit is contained in:
parent
a70ccb6d8b
commit
acac3e29b3
14
src/odoc.ml
14
src/odoc.ml
|
@ -327,17 +327,9 @@ module Gen (S : sig val sctx : SC.t end) = struct
|
||||||
:: (List.map libs ~f:(fun lib -> odocs (Lib lib)))
|
:: (List.map libs ~f:(fun lib -> odocs (Lib lib)))
|
||||||
) in
|
) in
|
||||||
let html_files =
|
let html_files =
|
||||||
let closure =
|
let closure = Lib.closure libs in
|
||||||
match Lib.closure libs with
|
let deps = Dep.deps closure in
|
||||||
| Ok closure -> closure
|
List.map odocs ~f:(to_html ~deps ~requires:closure) in
|
||||||
| Error _ ->
|
|
||||||
(* CR diml for rgrinberg: this branch needs a comment, I
|
|
||||||
don't understand why we fallback to not taking the
|
|
||||||
transitive closure in case of error. *)
|
|
||||||
libs
|
|
||||||
in
|
|
||||||
let deps = Dep.deps (Ok closure) in
|
|
||||||
List.map odocs ~f:(to_html ~deps ~requires:(Ok closure)) in
|
|
||||||
List.iter (
|
List.iter (
|
||||||
Dep.html_alias (Pkg pkg)
|
Dep.html_alias (Pkg pkg)
|
||||||
:: List.map ~f:(fun lib -> Dep.html_alias (Lib lib)) libs
|
:: List.map ~f:(fun lib -> Dep.html_alias (Lib lib)) libs
|
||||||
|
|
Loading…
Reference in New Issue