matthieu
/
dune
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add error for %{read:x} in wrong place 

Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
This commit is contained in:
Rudi Grinberg 2018-07-08 17:18:38 +07:00
parent bfd246c667
commit a24b55ed81
3 changed files with 45 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/blackbox-tests/dune.inc
View File

@ -168,6 +168,14 @@
test-cases/force-test
(progn (run %{exe:cram.exe} -test run.t) (diff? run.t run.t.corrected)))))
(alias
(name form-error)
(deps (package dune) (source_tree test-cases/form-error))
(action
(chdir
test-cases/form-error
(progn (run %{exe:cram.exe} -test run.t) (diff? run.t run.t.corrected)))))
(alias
(name gen-opam-install-file)
(deps (package dune) (source_tree test-cases/gen-opam-install-file))
@ -659,6 +667,7 @@
(alias findlib)
(alias findlib-error)
(alias force-test)
(alias form-error)
(alias gen-opam-install-file)
(alias github20)
(alias github24)
@ -737,6 +746,7 @@
(alias findlib)
(alias findlib-error)
(alias force-test)
(alias form-error)
(alias gen-opam-install-file)
(alias github20)
(alias github24)

1
test/blackbox-tests/test-cases/form-error/dune Normal file
View File

@ -0,0 +1 @@
(copy_files %{read:x}/*)

34
test/blackbox-tests/test-cases/form-error/run.t Normal file
View File

@ -0,0 +1,34 @@
we're getting an acceptable error message when adding a macro form in an
inappropariate place:
$ dune build
Info: creating file dune-project with this contents: (lang dune 1.0)
/-----------------------------------------------------------------------
| Internal error: Fiber.Execution_context.forward_error: error handler raised.
| Invalid_argument("atom '%{read:x}' cannot be in dune syntax")
| Raised at file "pervasives.ml", line 33, characters 20-45
| Called from file "src/usexp/usexp.ml", line 26, characters 31-52
| Called from file "list.ml", line 100, characters 12-15
| Called from file "src/usexp/usexp.ml", line 36, characters 4-96
| Called from file "list.ml", line 100, characters 12-15
| Called from file "src/usexp/usexp.ml", line 36, characters 4-96
| Called from file "format.ml", line 1288, characters 32-48
| Called from file "format.ml", line 1337, characters 20-38
| Called from file "src/report_error.ml", line 108, characters 4-12
| Called from file "src/fiber/fiber.ml", line 243, characters 6-18
| Re-raised at file "src/fiber/fiber.ml", line 39, characters 19-26
| Called from file "src/fiber/fiber.ml", line 56, characters 6-20
|
| Original exception was: Invalid_argument("atom '%{read:x}' cannot be in dune syntax")
| Raised at file "pervasives.ml", line 33, characters 20-45
| Called from file "src/usexp/usexp.ml", line 26, characters 31-52
| Called from file "list.ml", line 100, characters 12-15
| Called from file "src/usexp/usexp.ml", line 36, characters 4-96
| Called from file "list.ml", line 100, characters 12-15
| Called from file "src/usexp/usexp.ml", line 36, characters 4-96
| Called from file "format.ml", line 1288, characters 32-48
| Called from file "format.ml", line 1337, characters 20-38
| Called from file "src/report_error.ml", line 108, characters 4-12
| Called from file "src/fiber/fiber.ml", line 243, characters 6-18
\-----------------------------------------------------------------------
[1]