matthieu
/
dune
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't delete targets before executing a rule 

At the moment, this breaks incremental builds
This commit is contained in:
Jérémie Dimino 2017-03-05 12:33:49 +00:00
parent 292f423cda
commit 95eca26bf0
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/build_system.ml
View File

@ -246,7 +246,7 @@ let refresh_targets_timestamps_after_rule_execution t targets =
| exception _ -> Pset.add fn acc
| stat ->
let ts = stat.st_mtime in
Hashtbl.add t.timestamps ~key:fn ~data:ts;
Hashtbl.replace t.timestamps ~key:fn ~data:ts;
acc)
in
if not (Pset.is_empty missing) then
@ -318,7 +318,15 @@ let compile_rule t ~all_targets_by_dir ?(allow_override=false) pre_rule =
acc || prev_hash <> hash)
in
if rule_changed || min_timestamp t targets < max_timestamp t all_deps then begin
List.iter targets ~f:Path.unlink_no_err;
(* CR-someday jdimino: we should remove the targets to be sure
the action re-generate them, however it breaks incrementality
regarding [Write_file ...] actions, since they end up
systematically re-creating the file:
{[
List.iter targets ~f:Path.unlink_no_err;
]}
*)
Action.exec action >>| fun () ->
refresh_targets_timestamps_after_rule_execution t targets
end else