From 8c86604ee65f7a8433a62551b7eb3de4d65ccaeb Mon Sep 17 00:00:00 2001
From: Rudi Grinberg <rudi.grinberg@gmail.com>
Date: Wed, 11 Apr 2018 17:11:28 +0700
Subject: [PATCH] Add test to show that jbuilder mishandles ${null}

Jbuilder incorrectly infers ${null} to be a target
---
 test/blackbox-tests/jbuild                     | 9 +++++++++
 test/blackbox-tests/test-cases/null-dep/jbuild | 5 +++++
 test/blackbox-tests/test-cases/null-dep/run.t  | 4 ++++
 3 files changed, 18 insertions(+)
 create mode 100644 test/blackbox-tests/test-cases/null-dep/jbuild
 create mode 100644 test/blackbox-tests/test-cases/null-dep/run.t

diff --git a/test/blackbox-tests/jbuild b/test/blackbox-tests/jbuild
index 4d9bafd2..ca808c44 100644
--- a/test/blackbox-tests/jbuild
+++ b/test/blackbox-tests/jbuild
@@ -480,3 +480,12 @@
      (run ${exe:cram.exe} run.t)
      (diff? run.t run.t.corrected))))))
 
+(alias
+ ((name runtest)
+  (deps ((package jbuilder)
+         (files_recursively_in test-cases/null-dep)))
+  (action
+   (chdir test-cases/null-dep
+    (progn
+     (run ${exe:cram.exe} run.t)
+     (diff? run.t run.t.corrected))))))
diff --git a/test/blackbox-tests/test-cases/null-dep/jbuild b/test/blackbox-tests/test-cases/null-dep/jbuild
new file mode 100644
index 00000000..6f0ecf69
--- /dev/null
+++ b/test/blackbox-tests/test-cases/null-dep/jbuild
@@ -0,0 +1,5 @@
+(jbuild_version 1)
+
+(alias
+ ((name runtest)
+  (action (with-stdout-to ${null} (echo "hello world")))))
diff --git a/test/blackbox-tests/test-cases/null-dep/run.t b/test/blackbox-tests/test-cases/null-dep/run.t
new file mode 100644
index 00000000..972d5375
--- /dev/null
+++ b/test/blackbox-tests/test-cases/null-dep/run.t
@@ -0,0 +1,4 @@
+  $ jbuilder runtest --debug-dependency-path
+  File "jbuild", line 5, characters 26-33:
+  Warning: Aliases must not have targets, this target will be ignored.
+  This will become an error in the future.