From 76c1a32da4642190059b2c459d4b5dd018854880 Mon Sep 17 00:00:00 2001
From: Rudi Grinberg <rudi.grinberg@gmail.com>
Date: Tue, 8 May 2018 19:27:02 +0700
Subject: [PATCH] Add tests for invalid alias paths

---
 test/blackbox-tests/dune.inc                           | 10 ++++++++++
 .../test-cases/bad-alias-error/absolute-path/jbuild    |  3 +++
 .../bad-alias-error/outside-workspace/jbuild           |  4 ++++
 test/blackbox-tests/test-cases/bad-alias-error/run.t   |  5 +++++
 4 files changed, 22 insertions(+)
 create mode 100644 test/blackbox-tests/test-cases/bad-alias-error/absolute-path/jbuild
 create mode 100644 test/blackbox-tests/test-cases/bad-alias-error/outside-workspace/jbuild
 create mode 100644 test/blackbox-tests/test-cases/bad-alias-error/run.t

diff --git a/test/blackbox-tests/dune.inc b/test/blackbox-tests/dune.inc
index f8dbff41..052e0b58 100644
--- a/test/blackbox-tests/dune.inc
+++ b/test/blackbox-tests/dune.inc
@@ -6,6 +6,14 @@
     test-cases/aliases
     (progn (run ${exe:cram.exe} -test run.t) (diff? run.t run.t.corrected))))))
 
+(alias
+ ((name bad-alias-error)
+  (deps ((package dune) (files_recursively_in test-cases/bad-alias-error)))
+  (action
+   (chdir
+    test-cases/bad-alias-error
+    (progn (run ${exe:cram.exe} -test run.t) (diff? run.t run.t.corrected))))))
+
 (alias
  ((name byte-code-only)
   (deps ((package dune) (files_recursively_in test-cases/byte-code-only)))
@@ -446,6 +454,7 @@
  ((name runtest)
   (deps
    ((alias aliases)
+    (alias bad-alias-error)
     (alias byte-code-only)
     (alias c-stubs)
     (alias configurator)
@@ -499,6 +508,7 @@
  ((name runtest-no-deps)
   (deps
    ((alias aliases)
+    (alias bad-alias-error)
     (alias byte-code-only)
     (alias c-stubs)
     (alias configurator)
diff --git a/test/blackbox-tests/test-cases/bad-alias-error/absolute-path/jbuild b/test/blackbox-tests/test-cases/bad-alias-error/absolute-path/jbuild
new file mode 100644
index 00000000..789e60e0
--- /dev/null
+++ b/test/blackbox-tests/test-cases/bad-alias-error/absolute-path/jbuild
@@ -0,0 +1,3 @@
+(alias
+ ((name runtest)
+  (deps ((alias /foo/bar)))))
diff --git a/test/blackbox-tests/test-cases/bad-alias-error/outside-workspace/jbuild b/test/blackbox-tests/test-cases/bad-alias-error/outside-workspace/jbuild
new file mode 100644
index 00000000..d5050b8d
--- /dev/null
+++ b/test/blackbox-tests/test-cases/bad-alias-error/outside-workspace/jbuild
@@ -0,0 +1,4 @@
+
+(alias
+ ((name runtest)
+  (deps ((alias ${ROOT}/../../../foobar)))))
diff --git a/test/blackbox-tests/test-cases/bad-alias-error/run.t b/test/blackbox-tests/test-cases/bad-alias-error/run.t
new file mode 100644
index 00000000..864f6496
--- /dev/null
+++ b/test/blackbox-tests/test-cases/bad-alias-error/run.t
@@ -0,0 +1,5 @@
+  $ dune runtest --root absolute-path 2>&1 | grep -v Entering
+  Invalid alias!
+  Tried to reference alias "/foo/bar"
+  $ dune runtest --root outside-workspace 2>&1 | grep -v Entering
+  Path outside the workspace: ./../../../foobar from _build/default