Add test for #734

test/blackbox-tests/dune.inc

@@ -193,6 +193,14 @@
      (run ${exe:cram.exe} -skip-versions 4.02.3 -test run.t)
      (diff? run.t run.t.corrected))))))
 
+(alias
+ ((name github734)
+  (deps ((package dune) (files_recursively_in test-cases/github734)))
+  (action
+   (chdir
+    test-cases/github734
+    (progn (run ${exe:cram.exe} -test run.t) (diff? run.t run.t.corrected))))))
+
 (alias
  ((name github759)
   (deps ((package dune) (files_recursively_in test-cases/github759)))
@@ -492,6 +500,7 @@
     (alias github644)
     (alias github660)
     (alias github717-odoc-index)
+    (alias github734)
     (alias github759)
     (alias github761)
     (alias include-loop)
@@ -546,6 +555,7 @@
     (alias github568)
     (alias github597)
     (alias github660)
+    (alias github734)
     (alias github759)
     (alias github761)
     (alias include-loop)

test/blackbox-tests/test-cases/github734/dune

@@ -0,0 +1,12 @@
+(alias
+ ((name foo)
+  (deps ((alias a)
+         (alias b)))))
+
+(alias
+ ((name a)
+  (deps (src/stubs/x.c))))
+
+(alias
+ ((name b)
+  (deps (src/bar.exe))))

test/blackbox-tests/test-cases/github734/run.t

@@ -0,0 +1,28 @@
+  $ jbuilder build @foo
+  Internal error, please report upstream including the contents of _build/log.
+  Description: 
+  ("Build_system.get_collector called on closed directory"
+   (dir _build/default/src/stubs))
+  Backtrace:
+  Raised at file "src/stdune/exn.ml", line 32, characters 5-10
+  Called from file "src/build_system.ml", line 1503, characters 18-47
+  Called from file "src/gen_rules.ml", line 495, characters 4-516
+  Called from file "list.ml", line 82, characters 20-23
+  Called from file "src/gen_rules.ml", line 643, characters 8-94
+  Called from file "src/stdune/exn.ml", line 21, characters 8-11
+  Re-raised at file "src/stdune/exn.ml", line 23, characters 30-37
+  Called from file "src/gen_rules.ml", line 959, characters 13-72
+  Called from file "src/stdune/list.ml", line 13, characters 10-13
+  Called from file "src/gen_rules.ml", line 955, characters 4-777
+  Called from file "src/gen_rules.ml", line 994, characters 19-30
+  Called from file "src/build_system.ml", line 889, characters 6-62
+  Called from file "src/build_system.ml", line 865, characters 6-59
+  Re-raised at file "src/build_system.ml", line 876, characters 6-17
+  Called from file "src/build_system.ml" (inlined), line 833, characters 32-63
+  Called from file "src/build_system.ml", line 843, characters 4-24
+  Called from file "src/build_interpret.ml", line 101, characters 24-40
+  Called from file "src/build_interpret.ml", line 60, characters 31-43
+  Called from file "src/build_interpret.ml", line 60, characters 31-43
+  Called from file "src/build_system.ml", line 1215, characters 10-108
+  Called from file "src/fiber/fiber.ml", line 359, characters 6-13
+  [1]

test/blackbox-tests/test-cases/github734/src/bar.ml

@@ -0,0 +1 @@
+Foo.test ()

test/blackbox-tests/test-cases/github734/src/dune

@@ -0,0 +1,9 @@
+(library
+ ((name foo)
+  (modules (foo))
+  (c_names (stubs/x))))
+
+(executable
+ ((name bar)
+  (modules (bar))
+  (libraries (foo))))

test/blackbox-tests/test-cases/github734/src/foo.ml

@@ -0,0 +1 @@
+external test : unit -> unit = "test"

test/blackbox-tests/test-cases/github734/src/stubs/x.c

@@ -0,0 +1,6 @@
+#include <caml/mlvalues.h>
+
+CAMLprim value test()
+{
+  return Val_unit;
+}