From 1a37977f628e3061c48447df6f2103a5c0df3235 Mon Sep 17 00:00:00 2001 From: Rudi Grinberg Date: Fri, 6 Jul 2018 19:32:46 +0700 Subject: [PATCH] Fix error message Signed-off-by: Rudi Grinberg --- src/super_context.ml | 3 ++- test/blackbox-tests/test-cases/dune-jbuild-var-case/run.t | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/super_context.ml b/src/super_context.ml index 48d2cfcd..126c3568 100644 --- a/src/super_context.ml +++ b/src/super_context.ml @@ -95,7 +95,8 @@ let expand_var_no_root t loc syntax_version var = if syntax_version < (1, 0) then v else - Loc.fail loc "Uppercase variables are removed in dune files. Use: %%{%s}" + Loc.fail loc "Uppercase variables are removed in dune files.@.\ + Hint: Did you mean %%{%s} instead?" (String.lowercase var) end diff --git a/test/blackbox-tests/test-cases/dune-jbuild-var-case/run.t b/test/blackbox-tests/test-cases/dune-jbuild-var-case/run.t index 49e77824..cda97388 100644 --- a/test/blackbox-tests/test-cases/dune-jbuild-var-case/run.t +++ b/test/blackbox-tests/test-cases/dune-jbuild-var-case/run.t @@ -6,7 +6,8 @@ All builtin variables are lower cased in Dune: $ dune runtest --root dune-upper Entering directory 'dune-upper' File "dune", line 3, characters 41-46: - Error: Uppercase variables are removed in dune files. Use: %{make} + Error: Uppercase variables are removed in dune files. + Hint: Did you mean %{make} instead? [1] jbuild files retain the the old names: